Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v14 #409

Merged
merged 18 commits into from
Jul 10, 2023
Merged

feat: v14 #409

merged 18 commits into from
Jul 10, 2023

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Apr 13, 2023 •
edited
Loading

BREAKING CHANGE: onUnhandledRequest middleware option is removed
BREAKING CHANGE: Drop support for NodeJS v14, v16
BREAKING CHANGE: Replace support for Node.js http(s) Agents with documentation on using fetch dispatchers instead (via @octokit/request)
BREAKING CHANGE: Remove ability to pass custom request options, except from method, headers, body, signal (via @octokit/request)

@baoshan
fix(middleware): oauth-app has no onUnhandledRequest option (#337)
e88581e 
BREAKING CHANGE: `onUnhandledRequest` middleware option is removed
@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Apr 13, 2023
@wolfy1339 wolfy1339 mentioned this pull request Apr 14, 2023
Closed
1 task
@gr2m
Copy link
Contributor

gr2m commented May 21, 2023 •
edited
Loading

I wonder if we could remove middlewares from this release as part of the breaking change? The createNodeMiddleware function has node-specific logic, which actually goes counter our efforts to make Octokit work cross platforms. Same with the middlewares in @octokit/oauth-app: https://github.com/octokit/oauth-app.js#middlewares

I would move out the middlewares into their own packages, like @octokit/middleware-node-app, @octokit/middleware-node-oauth-app, @octokit/middleware-aws-oauth-app, etc.

It would be yet another "plugin" type, besides Octokit plugins and Octokit auth strategies.

We had some prior discussion in that direction here: octokit/oauth-app.js#333

Any thoughts? @octokit/js @octokit/js-community @baoshan

@wolfy1339 wolfy1339 mentioned this pull request Jun 13, 2023
Closed
1 task
@renovate @wolfy1339 @kfcampbell
fix(deps): update dependency @octokit/plugin-paginate-rest to v7 (#424)
88d9f22 
* build(deps): lock file maintenance (#421)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): upgrade `@octokit/auth-app` (#422)

This should help make sure that users of CDNs like esm.sh get the correct working version.

Currently, it is loading version 4.0.10 of `@octokit/auth-app` which is a broken release

* build(deps): lock file maintenance

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @octokit/plugin-paginate-rest to v7

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: wolfy1339 <[email protected]>
Co-authored-by: Keegan Campbell <[email protected]>
@kfcampbell kfcampbell mentioned this pull request Jun 16, 2023
Merged
gr2m
gr2m previously approved these changes Jun 18, 2023
View reviewed changes
@gr2m gr2m dismissed their stale review June 18, 2023 18:06

approved by accident

gr2m
gr2m reviewed Jun 20, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@kfcampbell kfcampbell mentioned this pull request Jun 21, 2023
Closed
1 task
@nickfloyd nickfloyd mentioned this pull request Jun 27, 2023
Closed
63 tasks
@nickfloyd
Copy link
Contributor

This should be good to go now! cc: @wolfy1339 @gr2m

@wolfy1339
Copy link
Member Author

There's still some dependencies that need to be updated

@nickfloyd
Copy link
Contributor

There's still some dependencies that need to be updated

Ok... I'll have a look at what's left.

@wolfy1339
Copy link
Member Author

Only waiting on octokit/oauth-app.js#436, then this will be ready

@wolfy1339 wolfy1339 marked this pull request as ready for review July 10, 2023 21:21
@wolfy1339
Copy link
Member Author

Also, octokit/plugin-paginate-rest.js#541

@wolfy1339
Copy link
Member Author

This is good to go now. Let's ship this 🚀

@wolfy1339 wolfy1339 merged commit b329da2 into main Jul 10, 2023
@wolfy1339 wolfy1339 deleted the beta branch July 10, 2023 21:55
@github-actions
Copy link

🎉 This PR is included in version 14.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscard0m oscard0m oscard0m approved these changes

@nickfloyd nickfloyd nickfloyd approved these changes

@gr2m gr2m Awaiting requested review from gr2m

@kfcampbell kfcampbell Awaiting requested review from kfcampbell

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wolfy1339 @gr2m @nickfloyd @oscard0m @baoshan