Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missed paths to require app auth #236

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

suhaibmujahid
Copy link
Contributor

The endpoint /app/hook/config requires app auth. However, it is not on the list.

Currently, we get the following error:

 Error: [@octokit/auth-app] installationId option is required for installation authentication.

The documentation mentions the following:

You must use a JWT to access this endpoint.
https://docs.github.com/en/free-pro-team@latest/rest/reference/apps#webhooks

@gr2m
Copy link
Contributor

gr2m commented Dec 8, 2020

Thanks!

I quickly checked the latest docs. We have a few more missing:

Could you add these, too, please?

@suhaibmujahid suhaibmujahid changed the title fix: Add /app/hook/config as requires app auth fix: Add missed paths to require app auth Dec 9, 2020
@suhaibmujahid
Copy link
Contributor Author

Thanks @gr2m!

I added the paths that you mentioned, and I updated the title to fit the change.

@gr2m gr2m added the Type: Feature New feature or request label Dec 9, 2020
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 💐

@gr2m gr2m merged commit 2067a8a into octokit:master Dec 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2020

🎉 This PR is included in version 2.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants