[TypeScript] REST API route completion is not triggered

[ghost]

What happened?

API route completion is not triggered when I use the octokit.request()

What did you expect to happen?

When starting to write the API route, I was expecting to have an API route completion but I don't.
I found (unexpectedly) that using a new pair of parenthesis when calling the method, I do get an API route completion.

How it should be ;

const octokit = new Octokit({ auth: `personal-access-token123` });

const response = await octokit.request(
    "GET /orgs/{org}/repos",
    {
          org: "octokit",
          type: "private",
    }
);

What I have to do ;

const octokit = new Octokit({ auth: `personal-access-token123` });

const response = await octokit.request(
    ("GET /orgs/{org}/repos"),
    {
         org: "octokit",
         type: "private",
    }
);

[wolfy1339]

Can you share some more details regarding your setup?
Editor and editor version, OS, NodeJS version

[wolfy1339]

I'm not sure this a bug with our code. This simply looks like an oddity with how the typescript types are processed and auto complete

[ghost]

I'm using the latest version of Vscode (v1.68.1) on Windows 10.

I'm using NodeJS version 18.3.0.

[gr2m]

I observed the same problem myself, it's very odd! And i was able to confirm that your mention workaround using () as in ("GET /orgs/{org}/repos") works! It feels to me like a bug with VS Code, but I thought it was still working a few days back and suddenly the behavior began.

I'd very much appreciate any help with digging into this

[wolfy1339]

It feels to me like a bug with VS Code

The same problem happens on the Typescript Playground, I don't think it's limited to VS Code

[gr2m]

This is so funky. Here is the TypeScript playground link to experiment, and a video recording to showcase the problem

Screen.Recording.2022-06-21.at.4.11.14.PM.mov

[gr2m]

Some insights by @levenleven

it works if you switch to earlier TypeScript version
Playground

and

It seems to work if you split https://github.com/octokit/types.ts/blob/master/src/RequestInterface.ts#L26-L33 to two overloads: one for known routes (keyof Endpoints) and another one for "catch" all string
Playground

[ghost]

While the PR has fixed the route completion, it looks like the PR has broke options completion

[timrogers]

@HoTKreeZy Oh dear! 😬 Would you mind creating a new issue so we can track what you’re seeing?