Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Octokit version 4.2.2 has a breaking change dependency upgrade #575

Closed
1 task done
erinleigh90 opened this issue Jun 16, 2023 · 2 comments · Fixed by #577
Closed
1 task done

[BUG]: Octokit version 4.2.2 has a breaking change dependency upgrade #575

erinleigh90 opened this issue Jun 16, 2023 · 2 comments · Fixed by #577
Labels
released on @beta released Type: Bug Something isn't working as documented

Comments

@erinleigh90
Copy link

What happened?

Octokit version 4.2.2 bumped their dependency on @octokit/request-error to ^4.0.0, which includes a breaking change for anyone using Node 16: this should have been a major version bump.

Versions

Octokit.js 4.2.2, Node 16.20.0

Relevant log output

error @octokit/[email protected]: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.14.2"
error Found incompatible module.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@erinleigh90 erinleigh90 added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jun 16, 2023
@wolfy1339 wolfy1339 added Priority: Critical and removed Status: Triage This is being looked at and prioritized labels Jun 16, 2023
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jun 16, 2023
@kfcampbell kfcampbell mentioned this issue Jun 16, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Jun 16, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 4.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @beta released Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): revert breaking dependency changes octokit/core.js
2 participants
@wolfy1339 @erinleigh90