[BUG]: OctokitOptions declared locally but not exported

[mcgear]

What happened?

I am trying to use OctokitOptions in a typescript project for DenoJS, but am getting the following error when using this import import { OctokitOptions } from "@octokit/core";

Not sure how to handle, thanks for the help.

Versions

octokit/core: https://esm.sh/@octokit/[email protected]

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

You are getting that error because that export does not exist.

It's imported in the index.ts file but not exported.

If you absolutely need to import it, you can use:

import type from "@octokit/core/dist-types/types.d":

[mcgear]

Its mostly for cleanliness of some helper functions we are establishing for Octokit initialization. Any plans to add this as an export? Would it be an accepted PR?

[wolfy1339]

You can also do this:

type OctokitOptions = ConstructorParameters<Octokit>;

I'm open to a PR

[mcgear]

Created PR #646

[github-actions]

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

• GitHub release
• npm package (@release-5.x dist-tag)

Your semantic-release bot 📦🚀