Stop pulling in aws-lambda
which pulls in the huge aws-sdk
#330
Labels
Type: Maintenance
Any dependency, housekeeping, and clean up Issue or PR
What’s missing?
This module itself with all non-optional dependencies is quite small compared to the size of
aws-lambda
and its dependencies, which is +44x the size.Since optional dependencies are installed by default and there's no simple way of opting out of specific optional dependencies the change in #283 made most users of this module (and in turn the users of
octokit
) pull inaws-lambda
and in turnaws-sdk
, which is likely going to be the heaviest of all the modules in theirnode_modules
folder.Why?
If
aws-lambda
needs to be included as a dependency, then make it so that it will only actively be pulled in by those actively wanting it and avoid the drive-by adding of theaws-lambda
/aws-sdk
to everyone else.Alternatives you tried
I did try
npm ci --no-optional
and that worked, but also causes all optionals to be opt outed from, not just this one, and it was very easy to miss that it would help this nested behemoth from being pulled in.The text was updated successfully, but these errors were encountered: