-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove onUnhandledRequest middleware option #341
Remove onUnhandledRequest middleware option #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we release this as a beta to verify that @octokit/app
still works without the onUnhandledRequest
hook and to verify that you can easily build middleware.
882f7ac
to
4e5da8a
Compare
4e5da8a
to
6f5f025
Compare
There is also a draft PR for |
I've updated both PRs to merge into Can you add |
BREAKING CHANGE: drop onUnhandledRequest middleware option support
6f5f025
to
f14ff6d
Compare
Thanks. I’ve appended a |
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR is based on the idea that Octokit middlewares (not limited to
oauth-app.js
) respect below proposed principle:pathPrefix
(returns a predictable404
response for unknown routes)pathPrefix
(but could be easily customized in an idiomatic way of the specific framework/runtime)This PR also removes the (already deprecated) Cloudflare handler because this is a breaking change which leads to a major version bump.