-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add redirectUrl as a constructor option #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A+ PR, would merge again :D
Bonus points if you a separate commit with only the tests first next time, so that we see the ❌, then push the fix/feat commits to get the ✅ . That way we can see right away that the tests actually failed before your implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh forgot one thing: could you update the Constructor options in the README please?
aa137d6
to
da11a12
Compare
There seems to be conflicts, so I will rebase first. |
da11a12
to
9b1772c
Compare
9b1772c
to
b82a8d2
Compare
Documented the parameter in the README. Also, since I was rebasing to fix the conflict anyway, I went ahead and split the first commit into a test only commit and feature commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, really great work 💐💝
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you for looking into the PRs so quickly. |
🎉 This PR is included in version 5.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #367
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Feature