ci: stop testing against NodeJS v14, v16 #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
added
Type: Breaking change
wolfy1339
force-pushed
the
remove-eol-node-versions
branch
2 times, most recently
from
35ab257 to
475bb2f
Compare
BREAKING CHANGE: Drop support for NodeJS v14, v16
wolfy1339
changed the title
wolfy1339
force-pushed
the
remove-eol-node-versions
branch
from
5e3fb2e to
5d97da0
Compare
|
@wolfy1339 Node 16 is still supported until September 2023. What's the justification for stripping it before then? |
|
It was suggested by @gr2m in octokit/webhooks.js#849 (review) In order to avoid making another breaking release in a couple months |
kfcampbell
approved these changes
May 15, 2023
|
Something is up with branch protection. It currently requires node 10 and 12. which were removed a whiles back |
most likely we didn't update the |
|
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop support for NodeJS v14, v16