Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RequestError support #2465

Merged
merged 11 commits into from
Jun 20, 2023
Merged

feat: add RequestError support #2465

merged 11 commits into from
Jun 20, 2023

Conversation

DariuszPorowski
Copy link
Contributor

@DariuszPorowski DariuszPorowski commented Jun 1, 2023 •
edited
Loading

Resolves #2464

Behavior

Before the change?

  • Lack of RequestError support

After the change?

  • Added RequestError support by re-exporting from @octokit/request-error

Other information

  • N/A

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features) N/A
  • Docs have been reviewed and added / updated if needed (for bug fixes / features) N/A
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Jun 1, 2023
@wolfy1339
Copy link
Member

I don't understand why the coverage is going down because of that export.

@DariuszPorowski
Copy link
Contributor Author

@wolfy1339 I think figured out, my bad, missing top-level export and missing test. Now should be good :)

@wolfy1339
Copy link
Member

Can you fix the conflicts, then we will be good to go

wolfy1339
wolfy1339 reviewed Jun 17, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
wolfy1339
wolfy1339 reviewed Jun 17, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 enabled auto-merge (squash) June 17, 2023 00:43
auto-merge was automatically disabled June 17, 2023 02:27

Head branch was pushed to by a user without write access

gr2m
gr2m approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR 💐

@gr2m gr2m merged commit 46b5f2f into octokit:main Jun 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DariuszPorowski DariuszPorowski deleted the 2464-request-error branch June 21, 2023 00:06
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@flaan4me flaan4me mentioned this pull request May 24, 2024
Open
@filipeoliveiraa filipeoliveiraa mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released on @beta released on @2.x released Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Include @octokit/request-error in the bundle
3 participants
@DariuszPorowski @wolfy1339 @gr2m