[BUG]: Property 'login' does not exist on type 'SerializeObject<UndefinedToOptional<{...}>>

[dantevvp]

What happened?

After updating Octokit from 2.0.14 to the latest version and running typecheck, I started seeing this error appearing for this code:

const { data: { installations } } = await octokit.rest.apps.listInstallationsForAuthenticatedUser();

installations.map((installation) => installation.account!.login)

Property 'login' does not exist on type 'SerializeObject<UndefinedToOptional<{ name?: string | null | undefined; email?: string | null | undefined; login: string; id: number; node_id: string; avatar_url: string; gravatar_id: string | null; url: string; html_url: string; ... 11 more ...; starred_at?: string | undefined; }>> | SerializeObject<...>'.

Property 'login' does not exist on type 'SerializeObject<UndefinedToOptional<{ description?: string | null | undefined; html_url: string; website_url?: string | null | undefined; id: number; node_id: string; name: string; slug: string; created_at: string | null; updated_at: string | null; avatar_url: string; }>>'

Is there something missing on my side? Or is this a bug? I noticed that the error does not appear if I try to access any of the following properties:

- avatar_url
- html_url
- id
- name?
- node_id

But it does happen for any other property, like description?. I can't seem to figure out if there's a pattern here. This worked fine in previous versions with openapi-types = 16.0.0

I apologize if this is not a bug. Thanks!

Versions

Octokit 3.1.0 with openapi-types on 18.0.0.

Previously, was using Octokit 2.0.14 with openapi-types on 16.0.0.

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[codingdiaz]

We are seeing this as well.

[wolfy1339]

Could be fixed by octokit/openapi#388

[wolfy1339]

@dantevvp Can you double check with the latest releases if this is fixed

[ellisio]

@wolfy1339 As of 22.2.0, this is still an issue.