Spelling #167
Spelling #167
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
| issues(first: 10, after: $curosr) { | ||
| issues(first: 10, after: $cursor) { |
There was a problem hiding this comment.
I don't think this test was testing what it thought it was testing.
| export function pageInfoBackwaredExported(): PageInfoBackward { | ||
| export function pageInfoBackwardExported(): PageInfoBackward { |
There was a problem hiding this comment.
this is a test, but, um... I'm not sure what it was doing either.
wolfy1339
added
Type: Breaking change
There was a problem hiding this comment.
I'm 👍 on this PR, the breaking change is minimal and easy to adjust for and the other changes are helpful. I'll hold off on merging for now as I know @wolfy1339 is doing a lot of (excellent) work releasing in our JS ecosystem right now and I don't want to step on toes. If Wolfy is good with a release here, I can merge/release.
|
I'm going to put this into the |
|
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* maint: spelling (#167) Signed-off-by: Josh Soref <[email protected]> BREAKING CHANGE: change spelling of `paginateGraphql` export to `paginateGraphQL` * feat: package is now ESM BREAKING CHANGE: package is now ESM * fix: add return type annotation --------- Co-authored-by: Josh Soref <[email protected]>
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
I'm happy to drop that one change. There were enough typos in the neighborhood that I'd like to make the argument that it's better to properly spell GraphQL than to inconsistently spell it including with typos.