-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retry "Something went wrong" GraphQL error #396
Merged
gr2m
merged 4 commits into
main
from
395-feat-retry-on-graphql-something-went-wrong-error
Jan 25, 2023
Merged
feat: retry "Something went wrong" GraphQL error #396
gr2m
merged 4 commits into
main
from
395-feat-retry-on-graphql-something-went-wrong-error
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
gr2m
force-pushed
the
395-feat-retry-on-graphql-something-went-wrong-error
branch
from
January 25, 2023 01:15
aae870c
to
6c21892
Compare
gr2m
commented
Jan 25, 2023
Comment on lines
+32
to
+44
if ( | ||
response.data.errors && | ||
/Something went wrong while executing your query/.test( | ||
response.data.errors[0].message | ||
) | ||
) { | ||
// simulate 500 request error for retry handling | ||
const error = new RequestError(response.data.errors[0].message, 500, { | ||
request: options, | ||
response, | ||
}); | ||
throw error; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there is a more elegant solution to this, but I couldn't think of any. This is a very specific handling of basically the 500 error status version of GraphQL queries.
mikesurowiec
approved these changes
Jan 25, 2023
nickfloyd
approved these changes
Jan 25, 2023
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #395