Add script to fix package json from build step

[oscard0m]

Resolves #405

---

Behavior

Before the change?

The released npm package is missing most of the files generated by the build step. dist-node, dist-types, dist-web... even though they are generated correctly.

You can read more about my explanation in the linked issue.

After the change?

I expected npm to read the file patterns correctly so we publish all the necessary files again.

Other information

This is a mix of an issue with npm@v9 (npm/cli#6164) and the fact we rely on pika for the build step. Pika has been archived since April 2022 so there is nothing we can do with Pika.

I'm opening a discussion to discuss what we should do: octokit/octokit.js#2403

Open questions

If we agree on this solution, we need to plan:

• How to merge and release this?
• What do we do with the rest of the repositories?
• What do we do with the already published versions with missing files?

---

Additional info

Pull request checklist

Because this is kind of a temporary hack, do you think I should add tests + documentation for this?

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Added the appropriate label for the given change

Does this introduce a breaking change?

No

Pull request type

Because of the problems is giving to users, I'm treating it as a bug: Type: Bug. In terms of semantic commit, let me know if I need to change ci() to fix()

---

[wolfy1339]

LGTM only one small code style issue

[oscard0m]

LGTM only one small code style issue

• How to merge and release this?
• What do we do with the rest of the repositories?
• What do we do with the already published versions with missing files?

[wolfy1339]

• How to merge and release this?
  Merge this as a bugfix release

• What do we do with the rest of the repositories?

I suppose we would need to apply the fix there as well

• What do we do with the already published versions with missing files?

Those versions could be marked as deprecated

[github-actions]

🎉 This PR is included in version 4.1.3 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[wolfy1339]

@oscard0m Can you run this through an octoherd script to apply this to all the repositories? Until we get esbuild done so releases aren't broken.

The following repos had recent releases:

• @octokit/app
• @octokit/oauth-app

[oscard0m]

@oscard0m Can you run this through an octoherd script to apply this to all the repositories? Until we get esbuild done so releases aren't broken.

The following repos had recent releases:

• @octokit/app
• @octokit/oauth-app

Sure! I will try to make some time during the weekend, but I'm unsure if I can. I'll keep you posted.

[oscard0m]

@wolfy1339 Created manual PRs for these two repos to remove friction:

• add script to fix package json from build step app.js#417
• fix(build): add script to fix package json from build step oauth-app.js#411