Retry all non 400/401/403 errors instead of only 500s

[SGrondin]

BREAKING CHANGE: Now retrying all non 400/401/403 errors instead of only 500s

[gr2m]

Changes look good, but we should also update the README. Instead of

Implements request retries for server error responses.

We should say sth like

Implements request retries for request error status codes other than 400, 4001 and 403?

I’m still not sure about the 404 🤔 I think the replication lag problem is mostly a problem when handling webhook events and I think we should solve it there. Otherwise I imagine people writing tests for their apps with deliberate 404s and then wonder why Octokit sends the same request again :/

Maybe we should add the 404 to the ignore codes and document how you can have retries on a per-request basis (like we already do)

What do you think?

[gr2m]

We should also ignore 304 error codes. "Not Modified" Responses are thrown so users can implement their caching solutions.

https://runkit.com/gr2m/octokit---conditional-request-example/1.0.0

[SGrondin]

Maybe we should add the 404 to the ignore codes and document how you can have retries on a per-request basis (like we already do)

I think you're right. I changed it and also documented how to override the ignore codes.

We should also ignore 304 error codes. "Not Modified" Responses are thrown so users can implement their caching solutions.

I didn't expect 3xx to be treated as errors at all. I've updated it so it doesn't retry 3xx.

[gr2m]

looking great!

[octokitbot]

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀