-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "abuse" language with "secondary" #439
Comments
Any kind of files (variable names?) or text files like Would the results of this search accurate enough? |
Yes
Looks like a good start 👍🏼 |
So text files or code too?
Sure! |
everything
Awesome, thank you! |
This comment has been minimized.
This comment has been minimized.
We had an internal tool using the API that started triggering secondary rate limits recently without any code change in our part. We were using v3.4.0 of the plugin and finally we figured we had to update it to v3.5.2 to get the fix in #437. This caused the plugin not to be triggered anymore until we also updated @octokit/rest from v18.2.0 to v18.10.0. Just in case anyone else is fighting a similar issue and comes across this :) |
@oscard0m, did you have any luck replacing the naming? |
Hey @Sid-ah , thanks getting back to me. I ended up not starting the PR for fixing this. I'm going to open a draft PR and tag you. Regarding when we could land this I'm not sure. Octokit is unmaintained since October 2021 (including all the automation flows to keep the ecosystem up to date with most recent GitHub Open API changes). Fortunately, it seems that there will be a team soon: 🍾 🥳 |
🎉 This issue has been resolved in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
GitHub recently renamed "abuse limits" to "secondary rate limits":
https://docs.github.com/en/rest/overview/resources-in-the-rest-api#secondary-rate-limits
We should make sure to update our wording across all @octokit repositories accordingly
The text was updated successfully, but these errors were encountered: