Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "abuse" language with "secondary" #439

Closed
gr2m opened this issue Sep 8, 2021 · 9 comments · Fixed by #455
Closed

Replace "abuse" language with "secondary" #439

gr2m opened this issue Sep 8, 2021 · 9 comments · Fixed by #455
Assignees
Labels
Type: Maintenance Tests, Refactorings, Automation, etc

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 8, 2021

GitHub recently renamed "abuse limits" to "secondary rate limits":
https://docs.github.com/en/rest/overview/resources-in-the-rest-api#secondary-rate-limits

We should make sure to update our wording across all @octokit repositories accordingly

@oscard0m
Copy link
Member

oscard0m commented Sep 8, 2021

GitHub recently renamed "abuse limits" to "secondary rate limits":
https://docs.github.com/en/rest/overview/resources-in-the-rest-api#secondary-rate-limits

We should make sure to update our wording across all @octokit repositories accordingly

Any kind of files (variable names?) or text files like Markdown, JSON, HTML?

Would the results of this search accurate enough?
https://github.com/search?q=org%3Aoctokit+abuse&type=code

@gr2m
Copy link
Contributor Author

gr2m commented Sep 8, 2021

Any kind of files (variable names?) or text files like Markdown, JSON, HTML?

Yes

Would the results of this search accurate enough?
https://github.com/search?q=org%3Aoctokit+abuse&type=code

Looks like a good start 👍🏼
Do you want to look into it yourself?

@oscard0m
Copy link
Member

oscard0m commented Sep 8, 2021

Any kind of files (variable names?) or text files like Markdown, JSON, HTML?

Yes

So text files or code too?

Would the results of this search accurate enough?

https://github.com/search?q=org%3Aoctokit+abuse&type=code

Looks like a good start 👍🏼

Do you want to look into it yourself?

Sure!

@gr2m
Copy link
Contributor Author

gr2m commented Sep 8, 2021

So text files or code too?

everything

Do you want to look into it yourself?

Sure!

Awesome, thank you!

@7upaesirik

This comment has been minimized.

@kaofelix
Copy link

We had an internal tool using the API that started triggering secondary rate limits recently without any code change in our part. We were using v3.4.0 of the plugin and finally we figured we had to update it to v3.5.2 to get the fix in #437. This caused the plugin not to be triggered anymore until we also updated @octokit/rest from v18.2.0 to v18.10.0. Just in case anyone else is fighting a similar issue and comes across this :)

@Sid-ah
Copy link

Sid-ah commented Feb 9, 2022

Any kind of files (variable names?) or text files like Markdown, JSON, HTML?

Yes

So text files or code too?

Would the results of this search accurate enough?

https://github.com/search?q=org%3Aoctokit+abuse&type=code

Looks like a good start 👍🏼
Do you want to look into it yourself?

Sure!

@oscard0m, did you have any luck replacing the naming?

@oscard0m
Copy link
Member

Any kind of files (variable names?) or text files like Markdown, JSON, HTML?

Yes

So text files or code too?

Would the results of this search accurate enough?

https://github.com/search?q=org%3Aoctokit+abuse&type=code

Looks like a good start 👍🏼
Do you want to look into it yourself?

Sure!

@oscard0m, did you have any luck replacing the naming?

Hey @Sid-ah , thanks getting back to me. I ended up not starting the PR for fixing this. I'm going to open a draft PR and tag you.

Regarding when we could land this I'm not sure. Octokit is unmaintained since October 2021 (including all the automation flows to keep the ecosystem up to date with most recent GitHub Open API changes).

Fortunately, it seems that there will be a team soon: 🍾 🥳

@oscard0m oscard0m added the Type: Maintenance Tests, Refactorings, Automation, etc label Feb 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Tests, Refactorings, Automation, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants