-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making of Jest Runner Integration #154
Comments
Thanks @idangoldman! @jgerigmeyer do you want to jump in here? |
Sounds good to me! I don't have a lot of experience with custom Jest runners, but I'd be happy to test/review a PR when you have one ready. Do you have specific questions about True integration with Jest? See our docs or package.json for how True is already testing itself using Jest. |
Ok, thanks for the support! I will play with some code and let you review and test what I will come up with. |
20 days later and here is the kickstart stone for SASS True jest runner. You can go over the git repo of the runner here-> jest-runner-sass-true The only roadblock holding it from working properly is that I wasn't able to inject Jest's This is a bit weird because Jest runs globally but for some reason it's not running globally inside the runner. Any ideas? There are a couple of tickets about making Jest's importable and not only run globally. There is even a PR (Allow importing Jest as an ES6 module #7571) on the subject but the Jest Team doesn't seem to have a priority for this. The discussion on the PR page suggests a couple of workaround solutions that I had no luck implementing. Any ideas? While working on the runner I had the chance to look at It would be great if Any thoughts? :) |
@idangoldman Sorry for the delay -- I just played with your custom runner a bit.
Yeah... that is weird. 🤷♂ It seems like custom runners themselves don't run in the "Jest" environment -- so there's not an obvious way to access
Interesting. I actually like the idea of decoupling True from test runners, if possible. Would you be interested in submitting a PR to True to get things started? Thanks! |
@jgerigmeyer Sorry for my delay as well... Missed the notification 😅
Yeah of course, didn't want to start writing anything before getting an approval from you. I will throw something together and submit a PR. |
Hello,
I love
True
and it helped me write tests for SCSS, now I want to help it and make aJest
runner package for it.Before starting, I wanted to get your view on the matter and what should I know from the
True
side that will come in handy and make this integration easier?The text was updated successfully, but these errors were encountered: