Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channelfilter #31

Open
lupomeo opened this issue Sep 18, 2018 · 0 comments
Open

channelfilter #31

lupomeo opened this issue Sep 18, 2018 · 0 comments

Comments

@lupomeo
Copy link

lupomeo commented Sep 18, 2018

Even if the channelsfilter is a good idea in principle I think it was badly done with the fake registration.
In my little opinion this code in plugin.py is too heavy for e2 and heavly slow down parsing performance:
fakeRecService = NavigationInstance.instance.recordService(sref, True)
if fakeRecService:
fakeRecResult = fakeRecService.start(True)
NavigationInstance.instance.stopRecordService(fakeRecService)
So i decided to skip with a patch because it seems to me that "the cure is worse than the disease" :)
Just my 2 cents :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant