Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rusty imports #6

Closed
JustusAdam opened this issue Sep 27, 2018 · 1 comment
Closed

Rusty imports #6

JustusAdam opened this issue Sep 27, 2018 · 1 comment

Comments

@JustusAdam
Copy link
Member

Imports currently use the syntax use sf module::qual (f1, f2);.

Ironically enough this has just confused the hell out of me, which, considering that I wrote the bloody thing, may be an indication that its wrong to do that.

Perhaps instead we should fully commit to the syntax used by rust, which is use sf module::qual::{f1, f2} because that is what I just (incorrectly) assumed it was.

I'd like an opinion by @Feliix42 , whether this would invalidate too many of your test cases?

@sertel
Copy link

sertel commented Sep 27, 2018

Even if so, they would probably be very easy to fix. So please go ahead with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants