Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it intended behavior to not list all functions involved in smap as dependencies? #14

Open
Feliix42 opened this issue Oct 25, 2018 · 3 comments
Labels

Comments

@Feliix42
Copy link
Member

Feliix42 commented Oct 25, 2018

I just discovered that when writing a Rust-esque ohua file that involves a smap function (like this one), the compiled output will not list the ohua/lang functions
size, oneToN, smapFun and collect as sf dependencies. Is this intended behavior?

The compiled output for the above file can be found here.

@JustusAdam
Copy link
Member

I think so. The way I wrote it was that basically anything the user imports via explicit import declarations end up as sf dependencies and not the internal stuff, with the reasoning being that these should exist anyway.

However if you wold prefer we add them to the dependencies list that could certainly be done.

@Feliix42
Copy link
Member Author

But then, smap itself should not be listed as sf dependency, as @sertel pointed out correctly.

The rust implementation uses the operators itself and resolves ohua/lang dependencies internally.

@JustusAdam
Copy link
Member

Oh ... heh 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants