Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typing and adjustment for ifFn in noria backend #31

Open
JustusAdam opened this issue Jun 10, 2021 · 0 comments
Open

Correct typing and adjustment for ifFn in noria backend #31

JustusAdam opened this issue Jun 10, 2021 · 0 comments
Labels

Comments

@JustusAdam
Copy link
Member

Currently the calculated type for ifFn in the Noria backend is basically A -> (A, A). This is technically incorrect and should instead be A -> (Idx<0>, Idx<1>).
However with that typing we must later ensure that when we remove the if, we also adjust the column that the filters behind the if operate on, i.e. we need to adjust their labels.

@JustusAdam JustusAdam added the bug label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant