Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Uris no longer include baseHref. #85

Open
1 of 3 tasks
dbrink opened this issue Jan 28, 2022 · 1 comment
Open
1 of 3 tasks

Redirect Uris no longer include baseHref. #85

dbrink opened this issue Jan 28, 2022 · 1 comment

Comments

@dbrink
Copy link

dbrink commented Jan 28, 2022

I'm submitting a:

  • Bug report
  • Feature request
  • Other (Describe below)

Current behavior

If an angular app is built with a baseHref, redirect Uris for signin and singout are not relative to this path when using OktaAuthGuard or signInWithRedirect.

Expected behavior

In v3 the redirect Uris were built using prepareExternalUrl which added the baseHref path. This appears to have been removed.

Minimal reproduction of the problem with instructions

Build angular app with baseHref. Serve on /base
ng build --base-href /base

Configure okta to use a redirectUri without the base path.

redirectUri: '/login/callback'

Trigger a sign-in redirect and the redirectUri will be /login/callback. This should trigger a 404 since the web app understanda the callback route as /base/login/callback.

Environment

  • Package version:5.1.0
  • Angular version: 13.1
  • Browser:Chrome
  • OS:Windows
  • Node version (node -v):16.13.2
  • Other:

Configuration

  • Okta application type:
@oleksandrpravosudko-okta
Copy link
Contributor

Thanks for the report @dbrink.

We will have this investigated and fixed.
Internal ref: OKTA-465065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants