From 21e4467b58ef440fea50e0caa92d9e7c2a2e5a60 Mon Sep 17 00:00:00 2001 From: Mike Mondragon Date: Wed, 14 Feb 2024 12:44:40 -0800 Subject: [PATCH 1/2] Fix bug where all flags were not being set on the config object. Closes #114 --- internal/config/config.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/internal/config/config.go b/internal/config/config.go index b7a70f4..92c10ae 100644 --- a/internal/config/config.go +++ b/internal/config/config.go @@ -325,18 +325,23 @@ func NewConfig(attrs *Attributes) (*Config, error) { awsIAMIdP: attrs.AWSIAMIdP, awsIAMRole: attrs.AWSIAMRole, awsRegion: attrs.AWSRegion, + awsSessionDuration: attrs.AWSSessionDuration, + cacheAccessToken: attrs.CacheAccessToken, + customScope: attrs.CustomScope, debug: attrs.Debug, debugAPICalls: attrs.DebugAPICalls, - expiryAWSVariables: attrs.ExpiryAWSVariables, exec: attrs.Exec, + expiryAWSVariables: attrs.ExpiryAWSVariables, fedAppID: attrs.FedAppID, format: attrs.Format, + keyID: attrs.KeyID, legacyAWSVariables: attrs.LegacyAWSVariables, + oidcAppID: attrs.OIDCAppID, openBrowser: attrs.OpenBrowser, openBrowserCommand: attrs.OpenBrowserCommand, + orgDomain: attrs.OrgDomain, privateKey: attrs.PrivateKey, privateKeyFile: attrs.PrivateKeyFile, - keyID: attrs.KeyID, profile: attrs.Profile, qrCode: attrs.QRCode, writeAWSCredentials: attrs.WriteAWSCredentials, From fcf0d2fa4ec95b68060ebf41a23522d2cf215034 Mon Sep 17 00:00:00 2001 From: Mike Mondragon Date: Wed, 14 Feb 2024 12:51:22 -0800 Subject: [PATCH 2/2] CL note --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 410784a..5c70ba2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,8 @@ TBD ### BUG FIXES -* Process credentials format was not emitting JSON correctly when `--write-aws-credentials` flag is present [#177](https://github.com/okta/okta-aws-cli/pull/177), thanks [@monde](https://github.com/monde)! +* Fix bug where all flags were not being set on the config object. [#177](https://github.com/okta/okta-aws-cli/pull/177), thanks [@monde](https://github.com/monde)! +* Process credentials format was not emitting JSON correctly when `--write-aws-credentials` flag is present [#173](https://github.com/okta/okta-aws-cli/pull/173), thanks [@monde](https://github.com/monde)! * Open browser and open browser command behavior was fouled in v2 release [#172](https://github.com/okta/okta-aws-cli/pull/172), thanks [@monde](https://github.com/monde)! ## 2.0.1 (January 31, 2024)