This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Update lib.d.ts #1033
Closed
Update lib.d.ts #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligns .ts file with docs in readme. adds custom jwks option to constructor, flags nonce parameter as optional for verifyIdToken
|
Internal Ref: OKTA-420060 |
|
Copied to okta/okta-jwt-verifier-js#10 and merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix [jwt-verifier]: Adds option parameter for custom jwks to the TS interface. Flags nonce as optional in the verifyIdToken TS declaration.
Docs in readme did not align with TS files as written.
Resolves: #1031
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using jwt-verifier in a TypeScript project you will encounter compile time errors when attempting to use the library as written in the docs.
Issue Number: #1031
What is the new behavior?
Typescript projects now accept the additional configuration option, and no longer require the optional parameter.
Does this PR introduce a breaking change?
Other information
Reviewers