test: add basic unit test - OKTA-327875 #149
Conversation
| "okta-hosted-login-server": "npm start --prefix okta-hosted-login/", | ||
| "test:okta-hosted-login": "export TEST_TYPE=implicit || setx TEST_TYPE \"implicit\" && protractor okta-oidc-tck/e2e-tests/okta-hosted-login/conf.js", | ||
| "custom-login-server": "npm start --prefix custom-login/", | ||
| "test:custom-login": "export TEST_TYPE=implicit || setx TEST_TYPE \"implicit\" && protractor okta-oidc-tck/e2e-tests/custom-login/conf.js", | ||
| "resource-server": "node scripts/node-resource-server.js", | ||
| "test:unit": "npm run test --prefix okta-hosted-login/ && npm run test --prefix custom-login/", |
There was a problem hiding this comment.
I'm not 100% sold on having the root level use npm run test:unit while the individual packages use npm run test, but I'm not 100% against it either.
There was a problem hiding this comment.
how about use test:unit in both places for consistency?
There was a problem hiding this comment.
After checking the code generated from create-react-app, I think it might make sense to keep the current naming conventions. As test in each individual package matches the script generated from CRA. And the root level test:unit is for the CI usage.
| let container; | ||
|
|
||
| beforeEach(() => { | ||
| container = document.createElement('div'); |
There was a problem hiding this comment.
it's copied from https://github.com/mraible/schematics/blob/main/src/add-auth/react/src/App.test.js
looks like mount should be enough here.
There was a problem hiding this comment.
after checking the doc, it's the suggested way from react test utils
Ref: https://reactjs.org/docs/test-utils.html#act
shuowu-okta
force-pushed
the
sw-add-basic-unit-test-OKTA-327875
branch
from
b3526d1 to
47d4c95
Compare
|
E2E passed in bacon:
|
shuowu-okta
force-pushed
the
sw-add-basic-unit-test-OKTA-327875
branch
from
47d4c95 to
21ed679
Compare
custom-login/package.json
Outdated
| }, | ||
| "jest": { | ||
| "moduleNameMapper": { | ||
| "^@okta/okta-auth-js$": "<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.min.js" |
There was a problem hiding this comment.
| "^@okta/okta-auth-js$": "<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.min.js" | |
| "^@okta/okta-auth-js$": "<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.umd.js" |
This is what fixed the tests for me.
There was a problem hiding this comment.
Finally figured out I was missing the MemoryRouter from react-router-dom for jest test.
okta-hosted-login/package.json
Outdated
| }, | ||
| "jest": { | ||
| "moduleNameMapper": { | ||
| "^@okta/okta-auth-js$": "<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.min.js" |
There was a problem hiding this comment.
| "^@okta/okta-auth-js$": "<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.min.js" | |
| "^@okta/okta-auth-js$": "<rootDir>/node_modules/@okta/okta-auth-js/dist/okta-auth-js.umd.js" |
Add basic unit tests for demo purposes per how to handle
okta-auth-jsdep issue.Resolves: #129