Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

https://api.github.com/repos/olefredrik/ in app.js imapcts YSlow #1203

Closed
nickbencino opened this issue Jan 10, 2018 · 2 comments
Closed

https://api.github.com/repos/olefredrik/ in app.js imapcts YSlow #1203

nickbencino opened this issue Jan 10, 2018 · 2 comments

Comments

@nickbencino
Copy link

nickbencino commented Jan 10, 2018

How can this bug be reproduced?

  1. Look in app.js and you will see the url
    https://api.github.com/repos/olefredrik/foundationpress?callback=foundationpressGithub&access_token=ed6229228dbc763038dbf1e68d0d8a4a0935b38a&callback=jQuery32105592909205515957_1515614253048&_=1515614253049
  2. Visit this GTmetrix URL, click YSlow and you can see the issue
    https://gtmetrix.com/reports/foundationpress.olefredrik.com/36fyvomx

What did you expect to happen?
I didn't really expect it to be there, I don't understand why it is.

What happened instead?
It was there and it impacts speed score with several page speed testers like GTmetrix... which makes clients unhappy.

Please List the Following:

  • OS & version:
    N/A
  • Node version (node -v) [Node v4+ is required] :
    N/A
  • FoundationPress version (see line 3 in package.json):
    Latest
  • Foundation version (found in node_modules/foundation-sites/package.json) :
    Latest
@JPOak
Copy link
Contributor

JPOak commented Jan 10, 2018

@forex4noobs That was removed last month I believe. #1188 . You can remove it it is just for the demo examples and to pull in the stargazers count I believe.

@colin-marshall
Copy link
Collaborator

@JPOak is correct. Closing this out. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants