Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Feature request: remove comments.php template #1291

Closed
derweili opened this issue Jul 4, 2018 · 4 comments
Closed

Feature request: remove comments.php template #1291

derweili opened this issue Jul 4, 2018 · 4 comments

Comments

@derweili
Copy link
Collaborator

derweili commented Jul 4, 2018

The FoundationPress theme comes with a custom comment form template (comments.php) that overwrites the wordpress default comment form with harcoded input fields.
Since is does not include any Foundation specific adjustments/functions I'm wondering if the custom template is really necassary.

The custom template has no advantages, but instead some disadvantages:

  • The Comment form does not automatically get updated when WordPress itself makes changes on the default comment form
  • Plugins that modify the Comment Form (adding, modifying or removing fields) don't work with this custom template.
  • As mentioned in GDPR support for Comment Forms #1289 most of the users in the EU use several plugins that modify the Comments Forms to comply with the GDPR. These Plugins do not work with the custom comments.php template

For these reasons I would recommend to remove the comments.php from FoundationPress.

@dantahoua
Copy link
Contributor

Are you sure there is nothing involved between comments and Foundation? Because there is the 'library/class-foundationpress-comments.php' file... But when I look at it, seems there is no reference to any Foundation class...
So I second that also, let's keeps the comment to wordpress or to the user who want to customize them...

@dantahoua
Copy link
Contributor

Just encounter a problem with comments.php... For the first time I use it! And there is a pluguin who is supposed to add a ReCaptcha on the comment form on the website. Without comments.php it works, but if I use the FoundationPress comments.php, it do not works... It seems we need to use the special comment filter and function to be sure everything works ok...

@derweili
Copy link
Collaborator Author

@dantahoua I think the best way ist to keep the comments.php but to replace the hardcoded comment form with the comment_form(); template tag

This template tag includes all necessary hooks to support third party plugins.

@derweili
Copy link
Collaborator Author

derweili commented Oct 29, 2018

solved by #1296

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants