Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure message of java execution is suppressed #21

Open
eyalroth opened this issue Mar 31, 2020 · 2 comments
Open

Failure message of java execution is suppressed #21

eyalroth opened this issue Mar 31, 2020 · 2 comments

Comments

@eyalroth
Copy link

If the java execution fails (in ScalastyleCheckTask), the exception is suppressed instead of being printed. This makes it extremely cumbersome to debug problems.

@olisikh
Copy link
Owner

olisikh commented Apr 19, 2020

Hi Eyal,

Thanks for reporting this.
Exception would now be logged by the plugin if --stacktrace or --full-stacktrace argument is provided to Gradle runtime.

Could you please check from your end using 3.3.1 version?

@eyalroth
Copy link
Author

The exception is now logged with --stacktrace, but it doesn't give much information of the reason of failure. It only mentions that the java has process finished with non-zero exit value 1, which could also mean that the check has failed but without any exception in the process of checking.

I believe this essentially stems from the scalastyle running as a separate process instead of from the gradle process itself. The org.scalastyle.Main class is intended for CLI usage I believe, and not for integration.

I would imagine this is why the failOnViolation option was dropped (#25).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants