Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This plugin should ignore code inside node_modules #82

Closed
quantizor opened this issue Feb 9, 2017 · 2 comments
Closed

This plugin should ignore code inside node_modules #82

quantizor opened this issue Feb 9, 2017 · 2 comments

Comments

@quantizor
Copy link

For example, my own code may be safe to prune propTypes, but react-router isn't, because they do some checks involving them at runtime in production mode: https://github.com/ReactTraining/react-router/blob/389df9c0ba603b758de4a979a34ee10276f9a8d0/modules/Router.js#L135
@quantizor quantizor mentioned this issue Feb 9, 2017
Closed
@oliviertassinari
Copy link
Owner

oliviertassinari commented Feb 9, 2017 •
edited
Loading

@yaycmyk I didn't know react-router was affected too. I'm reopening #70.

By the way, cool to see someone from @Zocdoc. Kind of the aboard reference at @doctolib.

@quantizor
Copy link
Author

Awesome ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quantizor @oliviertassinari