-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for L colorspace and extra channels. #14
Comments
@alexjc Thanks for your awesome work. Unfortunately I've run into an issue with Github actions package building and I have little time to fix it lately. It might also resolve the #10 issue building wheels for Windows and Mac OS. I would like to fix that first in order to make PyPI release with prebuilt wheels. If you have any ideas on how to manage building wheel packages for jxlpy in Github actions I would appreciate any help. |
Is there any more information than in #10? |
Not really. The current build pipeline is a bit hacky, it uses CIBW_BEFORE_ALL to build libjxl and then cibuildwheel to build and fix Python package. The libjxl build instructions are Linux specific and use some workarounds which don't work anymore with latest version of libjxl. |
How do you test it locally? I'll take a look. |
If you could merge #13 that would help, so I can get it working with the latest version. |
Awesome! Merged, Thanks again :) I've also somewhat tested your master branch and it seems like your change in |
Oh, yes I know what that is — relates to the extra channels. I will fix it... |
Unfortunately, my implementation of I set EDIT: Image too big to inline, but you can view it here: |
OK, it's fixed it was a bug in ImageMagick actually. |
For the record in case people are looking: I have implemented both these features in my own branch at https://github.com/alexjc/jxlpy.
Just need to merge #13 first, then I'll port them over!
The text was updated successfully, but these errors were encountered: