Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Royalties non optional during creation of listing #81

Open
satyamakgec opened this issue Jan 31, 2023 · 2 comments
Open

Make Royalties non optional during creation of listing #81

satyamakgec opened this issue Jan 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@satyamakgec
Copy link
Contributor

Context

In current implementation, Royalties are fetched and add as the sale cut within the transaction code. However, consumers of the NFTStorefrontV2 like marketplaces or third party apps have an option to not honor royalties during the creation of the listing. Now we want to make royalties mandatory.

Proposed Solution

Move the royalties from the transaction i.e sell_item.cdc to the createListing function code.

@satyamakgec satyamakgec added the enhancement New feature or request label Jan 31, 2023
@satyamakgec satyamakgec self-assigned this Jan 31, 2023
@bymi15
Copy link

bymi15 commented Feb 5, 2023

This would have implications for many NFT contracts that currently have royalties defined to be received in a specific currency (e.g. FlowToken). If the listing is in a different currency (e.g. DapperUtilityCoin), then the transaction would fail if the royalty receiver specified in the NFT contract doesn't have the receiver capability.
I guess this would force NFT projects to update their contracts / wallets to use the FungibleTokenSwitchboard

@bjartek
Copy link

bjartek commented Feb 6, 2023

I mentioned this when this contract was created. Royalties should be fetched from the Metadata.Royalties that is defined in the NFT when a listing is made. This should be made in the contract and not in the transaction as that can be faked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants