Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/badges #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature/badges #22

wants to merge 5 commits into from

Conversation

dkk
Copy link

@dkk dkk commented Jul 21, 2023

feat: ability to handle badges. Aka. issue #19

  • small refactoring: Tabbable is used directly at custom styles (changes the interface slightly => Major version change if you use semver)

@dkk
Copy link
Author

dkk commented Jul 21, 2023

Btw. I left DefaultTabItemStyle without a badge visualization, I didn't know if it was wanted.

@dkk dkk closed this Jul 21, 2023
@dkk dkk reopened this Jul 24, 2023
@onl1ner
Copy link
Owner

onl1ner commented Jul 31, 2023

Hello, @dkk!

Much appreciation for your work, but now I can't thoroughly review this PR, can't find a free time for it :( I will review it as soon as I will be free from work and life related stuff.

Thanks :)

@onl1ner onl1ner added the enhancement New feature or request label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkk @onl1ner