Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Acknowledge Deprecation Warnings #802

Closed
carldunham opened this issue Apr 29, 2021 · 6 comments
Closed

Feature request: Acknowledge Deprecation Warnings #802

carldunham opened this issue Apr 29, 2021 · 6 comments

Comments

@carldunham
Copy link
Contributor

Otherwise, it's going to be a long couple of months... 😅

@onsi
Copy link
Owner

onsi commented Apr 29, 2021

😅 heh, indeed. Which deprecation are you hitting in particular?

@carldunham
Copy link
Contributor Author

So far, just the JUnit generation that we use for CI

@onsi
Copy link
Owner

onsi commented Apr 29, 2021

Yeah makes sense. That particular deprecation is not actionable yet. I'm inclined to do something like:

"If the environment variable GINKGO_ACK_DEPRECATIONS=1.16 is set then Ginkgo won't emit deprecations. Subsequent version of 1.x will emit new deprecations though until you bump the version number in the deprecations env var."

The intent there is to make it so folks notice the new deprecations. Thoughts/ideas?

@carldunham
Copy link
Contributor Author

That would be awesome.

@onsi
Copy link
Owner

onsi commented May 4, 2021

hey @carldunham - this is now done in v1.16.2. Give it a whirl. I went with ACK_GINKGO_DEPRECATIONS=1.16.2 for the environment variable.

@carldunham
Copy link
Contributor Author

@onsi that works great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants