From 58c2318dddc6bd4f2eb92d8a15a717ed1d0d714f Mon Sep 17 00:00:00 2001
From: tripp <86533397+trippjoe@users.noreply.github.com>
Date: Mon, 30 Dec 2024 14:20:18 -0500
Subject: [PATCH] filter incompatible releases from version table (#642)

---
 src/routes/settings/versions/OfficialVersions.svelte | 3 +++
 src/routes/settings/versions/VersionList.svelte      | 8 ++------
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/routes/settings/versions/OfficialVersions.svelte b/src/routes/settings/versions/OfficialVersions.svelte
index 2cd685a2..38d7afc7 100644
--- a/src/routes/settings/versions/OfficialVersions.svelte
+++ b/src/routes/settings/versions/OfficialVersions.svelte
@@ -84,6 +84,9 @@
       ];
     }
 
+    // filter incompatible releases
+    releases = releases.filter((r) => r.downloadUrl !== undefined);
+
     // Sort releases by published date
     releases = releases.sort((a, b) => {
       if (a.date === undefined) {
diff --git a/src/routes/settings/versions/VersionList.svelte b/src/routes/settings/versions/VersionList.svelte
index c1beada3..0e31efb2 100644
--- a/src/routes/settings/versions/VersionList.svelte
+++ b/src/routes/settings/versions/VersionList.svelte
@@ -106,9 +106,7 @@
               <Button
                 class="py-0 dark:bg-transparent hover:dark:bg-transparent focus:ring-0 focus:ring-offset-0 disabled:opacity-50"
                 disabled={release.pendingAction ||
-                  (!release.isDownloaded &&
-                    release.downloadUrl !== undefined &&
-                    release.invalid)}
+                  (!release.isDownloaded && release.invalid)}
                 on:click={async () => {
                   if (release.isDownloaded) {
                     dispatch("removeVersion", { version: release.version });
@@ -128,11 +126,9 @@
                       "settings_versions_icon_removeVersion_altText",
                     )}
                   />
-                {:else if release.downloadUrl === undefined}
-                  <span>{$_("settings_versions_incompatibleVersion")}</span>
                 {:else if release.pendingAction}
                   <Spinner color="yellow" size={"6"} />
-                {:else if release.releaseType === "official" && release.downloadUrl !== undefined}
+                {:else if release.releaseType === "official"}
                   <IconDownload
                     class="text-xl"
                     color="#00d500"