Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Repository maintenance on opentelemetry-java #1699

Closed
tylerbenson opened this issue Sep 27, 2023 · 6 comments
Closed

REQUEST: Repository maintenance on opentelemetry-java #1699

tylerbenson opened this issue Sep 27, 2023 · 6 comments
Assignees
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@tylerbenson
Copy link
Member

tylerbenson commented Sep 27, 2023

Affected Repository

https://github.com/organizations/open-telemetry/settings/actions/runner-groups/8
https://github.com/open-telemetry/opentelemetry-java

Requested changes

  • Add opentelemetry-java to Repository Access > selected repositories config
  • Add open-telemetry/opentelemetry-java/.github/workflows/benchmark.yml@refs/heads/main,open-telemetry/opentelemetry-java/.github/workflows/benchmark-tags.yml@refs/heads/main, to Workflow access > selected workflows config

Purpose

Enable bare metal benchmark execution.

Expected Duration

permanently

Repository Maintainers

  • @open-telemetry/java-maintainers
@tylerbenson tylerbenson added the area/repo-maintenance Maintenance of repos in the open-telemetry org label Sep 27, 2023
@arminru arminru self-assigned this Sep 28, 2023
@arminru
Copy link
Member

arminru commented Sep 28, 2023

@tylerbenson I enrolled the repo and both workflows, please let me know if it works as expected.

@arminru
Copy link
Member

arminru commented Sep 28, 2023

For the main workflow it looks like it picked up the first commit adding the workflow definition:
https://github.com/open-telemetry/opentelemetry-java/actions/runs/6330283817

@arminru
Copy link
Member

arminru commented Sep 28, 2023

@tylerbenson @jack-berg The run failed with

Run benchmark-action/github-action-benchmark@v1
/usr/bin/git -c user.name=github-action-benchmark -c [email protected] -c http.https://github.com/.extraheader= fetch ***github.com/open-telemetry/opentelemetry-java.git benchmarks:benchmarks
fatal: couldn't find remote ref benchmarks

I can add a branch protection rule that excludes a branch named benchmark from the EasyCLA check (see #1577) so you can create an empty branch as described in #1695. I think this will also be necessary for the workflow to push its results there.
Let me know if I should do so.

cc @ocelotl as you'll likely face the same in #1700.

@tylerbenson
Copy link
Member Author

Thanks @arminru. I think the branch just needs to be created. I'll work with @jack-berg on that.

@tylerbenson
Copy link
Member Author

It's working!
https://open-telemetry.github.io/opentelemetry-java/

@jack-berg
Copy link
Member

Nice! Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
None yet
Development

No branches or pull requests

3 participants