Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fraughtful language from Redis telemetry #14688

Closed
hughesjj opened this issue Oct 3, 2022 · 12 comments
Closed

Migrate fraughtful language from Redis telemetry #14688

hughesjj opened this issue Oct 3, 2022 · 12 comments
Labels

Comments

@hughesjj
Copy link
Contributor

hughesjj commented Oct 3, 2022

Describe the issue you're reporting

While working on getting Redis metrics in I noticed we're still using non-inclusive terminology for some of the Redis telemetry. Redis has deprecated the use of terminology such as slave as of 2018. I see we've been migrating such language across the project, and wanted to track the same effort for Redis.

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/redisreceiver/metadata.yaml#L249

Might be cool to resurrect #3282 seeing as how it's Apache Licensed now

@hughesjj hughesjj added the needs triage New item requiring triage label Oct 3, 2022
@jpkrohling jpkrohling added good first issue Good for newcomers receiver/redis Redis related issues and removed needs triage New item requiring triage labels Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Pinging code owners: @pmcollins @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

@hughesjj, would you like to submit a PR for that?

@hughesjj
Copy link
Contributor Author

hughesjj commented Oct 9, 2022

@hughesjj, would you like to submit a PR for that?
So, I've looked into this a bit deeper.

They mentioned in the redis github issue about writing an alternative to the INFO command, and that they don't intend to change the output of INFO. I'm currently researching if we can find an alternate source for such information on replicas that INFO gives (I'm far from an expert in redis).

I know there are some commands with the migration applied, such as CLUSTER REPLICAS. Just need to verify coverage of the "alternative" commands vs redis INFO

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 9, 2022
@fatsheep9146
Copy link
Contributor

@hughesjj Any progress?

@hughesjj
Copy link
Contributor Author

Hey, actually yes! But, of course, things have blown up.

Schema processors might be useful to migrate older versions in a compatible manner. We need to figure out a good story across otel for how to let vendors know this ahead of time, and I'm bringing such up with the semantic conventions working group.

I have not yet completed auditing of the ways to get this information in non-fraughtful ways. I owe you (customers of this issue) a list of mappings from INFO to other api calls of what we I know we could migrate.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 13, 2023
@dmitryax dmitryax removed the Stale label Feb 13, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.
  • receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 23, 2023
@dmitryax dmitryax removed the Stale label Jun 23, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.
  • receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 23, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2023
@hughesjj
Copy link
Contributor Author

So, plan of attack

  1. add a new option to the receiver configuration, redis_semantic_convention of type string, that follows the redis semantic conventions
  2. Default behavior should be existing nomenclature
  3. Determine less fraughtful terminology where appropriate, and release in an new redis semantic conventions PR
  4. Add a feature gate to change default behavior to match either latest semantic conventions version, some hard coded value post acceptance of newer semantic conventions, or even some dynamic "introspect my redis.version" logic

[aside]
Really this plays into long standing opentelemetry issues where we don't have good standards around

  1. tracking the version of the thing we're monitoring
  2. actually using different semantic convention versions/preventing drift or gaps between semantic conventions and components such as receivers

In the case of redis, we're lucky that their backwards support doesn't bite us often (really, ever so far), but other well used components (prometheus, k8s for starters) do have evolving nomenclature and APIs in their own products that are backwards incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants