Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] remove all usage of Multiline from the fileconsumer package #14766

Closed
atingchen opened this issue Oct 7, 2022 · 1 comment
Closed
Labels
enhancement New feature or request pkg/stanza priority:needed Triagers reviewed the issue but need code owner to set priority

Comments

@atingchen
Copy link
Contributor

Can we remove all usage of Multiline from the fileconsumer package?

We cannot remove Multiline from the receivers that already depend on it. However, we may be able to have their config look like:

type FileLogConfig {
      fileconsumer.Config `mapstructure:",squash"`
      helper.Multiline    `mapstructure:",squash"`
}

Then what we need to do is identify the necessary interface that allow fileconsumer to work the same as it did before. Essentially, we would make fileconsumer always use "custom" split behavior. What do you think, is it possible?

Originally posted by @djaglowski in #14605 (review)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Pinging code owners: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg/stanza priority:needed Triagers reviewed the issue but need code owner to set priority
Projects
None yet
Development

No branches or pull requests

2 participants