Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loki] Add default labels job=service.namespace/service.name, instance=service.instance.id #18500

Closed
mar4uk opened this issue Feb 10, 2023 · 1 comment
Labels
enhancement New feature or request needs triage New item requiring triage

Comments

@mar4uk
Copy link
Contributor

mar4uk commented Feb 10, 2023

Component(s)

exporter/loki

Is your feature request related to a problem? Please describe.

Currently, the loki exporter set only one label by default: exporter=OTLP.
This label is not enough to correlate logs in Loki with Prometheus metrics.

Describe the solution you'd like

To correlate logs in Loki with Prometheus metrics at least two labels are needed: job=service.namespace/service.name and instance=service.instance.id.
Adding default essential labels will simplify configuration and allow correlation between logs and metrics out of the box

Describe alternatives you've considered

Users can set these labels manually via a resource processor

Additional context

No response

@mar4uk mar4uk added enhancement New feature or request needs triage New item requiring triage labels Feb 10, 2023
@mar4uk
Copy link
Contributor Author

mar4uk commented Feb 13, 2023

fixed in #18499

@mar4uk mar4uk closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

1 participant