[exporter/elasticsearch] refactor into submodules to start splitting encoders per signal #36881
+2,072
−1,795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
carsonip
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Thanks, that's a lot of work! Looks good at a high level. Feel free to break it down and we can get them in.
On the structure, I'm not 100% set on whether we split per signal or split per mapping mode. I have a feeling that per mapping mode will get slightly better cohesion and also will fit into the current mappingModel interface, but let me know what you think.
|
I don't mind splitting it per mapping mode rather than signal. I did per signal because that's mostly how core does it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR may remain a draft forever, and end up into multiple PRs to ease readability.
It splits the data conversion into multiple packages, with the intent of having one package for each signal. To improve readability and maintanability of the module.