-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Add Murmur3Hash converter #37027
Open
kaisecheng
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
kaisecheng:ottl_murmur3_func
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+410
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Murmur3Hash: Murmur3 32-bit hash represented as a signed integer - Murmur3Hash128: Murmur3 128-bit hash represented as two signed integers - Murmur3Hex: hexadecimal string in little-endian of the 32-bit Murmur3 hash - Murmur3Hex128: hexadecimal string in little-endian of the 128-bit Murmur3 hash
kaisecheng
requested review from
a team,
TylerHelmuth,
bogdandrutu,
evan-bradley,
jpkrohling,
djaglowski,
mx-psi,
songy23,
crobert-1,
ChrsMark and
mwear
as code owners
January 6, 2025 16:27
github-actions
bot
added
connector/count
connector/datadog
connector/routing
connector/signaltometrics
connector/sum
exporter/datadog
Datadog components
exporter/elasticsearch
exporter/honeycombmarker
internal/filter
pkg/ottl
processor/attributes
Attributes processor
processor/filter
Filter processor
processor/logdedup
processor/routing
Routing processor
processor/span
labels
Jan 6, 2025
github-actions
bot
added
processor/tailsampling
Tail sampling processor
processor/transform
Transform processor
testbed
labels
Jan 6, 2025
github-actions
bot
requested review from
ankitpatel96,
boostchicken,
carsonip,
dineshg13,
fchikwekwe,
greatestusername,
jade-guiton-dd,
JaredTan95,
kentquirk,
lahsivjar,
liustanley,
mackjmr,
MikeGoldsmith and
shalper2
January 6, 2025 16:27
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37027 +/- ##
=======================================
Coverage 79.63% 79.64%
=======================================
Files 2223 2224 +1
Lines 210283 210341 +58
=======================================
+ Hits 167456 167517 +61
- Misses 37211 37214 +3
+ Partials 5616 5610 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
connector/count
connector/datadog
connector/routing
connector/signaltometrics
connector/sum
exporter/datadog
Datadog components
exporter/elasticsearch
exporter/honeycombmarker
internal/filter
pkg/ottl
processor/attributes
Attributes processor
processor/filter
Filter processor
processor/logdedup
processor/routing
Routing processor
processor/span
processor/tailsampling
Tail sampling processor
processor/transform
Transform processor
testbed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add four murmur3 hash functions to convert the
target
to signed integer or hexadecimal string formatMurmur3Hash
returns a signed integer of the Murmur3 32-bit hashMurmur3Hash128
returns two signed integers of Murmur3 128-bit hashMurmur3Hex
returns a hexadecimal string in little-endian of the 32-bit Murmur3 hashMurmur3Hex128
returns a hexadecimal string in little-endian of the 128-bit Murmur3 hashExample:
Murmur3Hash("20250106")
Link to tracking issue
issue: #34077
supersedes: #34155
Testing
Documentation
readme