Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/tailsampling] Added debug logging to sampling decision caches #37038

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

portertech
Copy link
Contributor

Description

This pull-request adds debug logging to the sampling decision caches, making it a little easier to debug decisions.

"Trace ID is in the sampled cache" and "Trace ID is in the non-sampled cache" with the trace ID as a zap field.

@portertech portertech requested review from jpkrohling and a team as code owners January 6, 2025 20:29
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Jan 6, 2025
@portertech portertech changed the title [tailsamplingprocessor] Added debug logging to sampling decision cache [tailsamplingprocessor] Added debug logging to sampling decision caches Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (333f016) to head (b59ddb2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
processor/tailsamplingprocessor/processor.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37038      +/-   ##
==========================================
- Coverage   79.63%   79.63%   -0.01%     
==========================================
  Files        2223     2223              
  Lines      210283   210285       +2     
==========================================
- Hits       167467   167464       -3     
- Misses      37206    37213       +7     
+ Partials     5610     5608       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sean Porter <[email protected]>
@portertech portertech requested a review from jpkrohling January 7, 2025 19:55
@portertech portertech changed the title [tailsamplingprocessor] Added debug logging to sampling decision caches [processor/tailsampling] Added debug logging to sampling decision caches Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/tailsampling Tail sampling processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants