From 5a0870a8550b706c708ea5c0868b9b179d6c41ad Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Mon, 12 Feb 2024 09:28:56 -0800 Subject: [PATCH 1/3] [exporter/f5] deprecate exporter After discussion with @lquerel, he mentioned the component is no longer maintained at F5. Marking it as deprecated. Signed-off-by: Alex Boten --- exporter/f5cloudexporter/README.md | 7 ++++--- exporter/f5cloudexporter/doc.go | 1 + exporter/f5cloudexporter/go.mod | 1 + .../f5cloudexporter/internal/metadata/generated_status.go | 6 +++--- exporter/f5cloudexporter/metadata.yaml | 5 +++-- 5 files changed, 12 insertions(+), 8 deletions(-) diff --git a/exporter/f5cloudexporter/README.md b/exporter/f5cloudexporter/README.md index 63c4d0de2258..893ca3b7e25b 100644 --- a/exporter/f5cloudexporter/README.md +++ b/exporter/f5cloudexporter/README.md @@ -3,12 +3,13 @@ | Status | | | ------------- |-----------| -| Stability | [beta]: traces, metrics, logs | +| Stability | [deprecated]: traces, metrics, logs | | Distributions | [contrib], [observiq] | | Issues | [![Open issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aopen%20label%3Aexporter%2Ff5cloud%20&label=open&color=orange&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aexporter%2Ff5cloud) [![Closed issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aclosed%20label%3Aexporter%2Ff5cloud%20&label=closed&color=blue&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aexporter%2Ff5cloud) | -| [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@gramidt](https://www.github.com/gramidt) | +| [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | | +| Emeritus | [@gramidt](https://www.github.com/gramidt) | -[beta]: https://github.com/open-telemetry/opentelemetry-collector#beta +[deprecated]: https://github.com/open-telemetry/opentelemetry-collector#deprecated [contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib [observiq]: https://github.com/observIQ/observiq-otel-collector diff --git a/exporter/f5cloudexporter/doc.go b/exporter/f5cloudexporter/doc.go index be24ef8d2294..2006b5a40f06 100644 --- a/exporter/f5cloudexporter/doc.go +++ b/exporter/f5cloudexporter/doc.go @@ -3,5 +3,6 @@ //go:generate mdatagen metadata.yaml +// Deprecated: [v0.95.0] This package is deprecated and will be removed in a future release. // Package f5cloudexporter implements an OpenTelemetry Collector exporter that sends trace, metric, and log data to F5 Cloud. package f5cloudexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter" diff --git a/exporter/f5cloudexporter/go.mod b/exporter/f5cloudexporter/go.mod index 3b2c04cee8e5..d81bf893d51f 100644 --- a/exporter/f5cloudexporter/go.mod +++ b/exporter/f5cloudexporter/go.mod @@ -1,3 +1,4 @@ +// Deprecated: [v0.95.0] This package is deprecated and will be removed in a future release. module github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter go 1.20 diff --git a/exporter/f5cloudexporter/internal/metadata/generated_status.go b/exporter/f5cloudexporter/internal/metadata/generated_status.go index a7dc09b3ad15..e86dd6f8a3b0 100644 --- a/exporter/f5cloudexporter/internal/metadata/generated_status.go +++ b/exporter/f5cloudexporter/internal/metadata/generated_status.go @@ -13,9 +13,9 @@ var ( ) const ( - TracesStability = component.StabilityLevelBeta - MetricsStability = component.StabilityLevelBeta - LogsStability = component.StabilityLevelBeta + TracesStability = component.StabilityLevelDeprecated + MetricsStability = component.StabilityLevelDeprecated + LogsStability = component.StabilityLevelDeprecated ) func Meter(settings component.TelemetrySettings) metric.Meter { diff --git a/exporter/f5cloudexporter/metadata.yaml b/exporter/f5cloudexporter/metadata.yaml index 1c59a86d4f37..1906d9ff9b99 100644 --- a/exporter/f5cloudexporter/metadata.yaml +++ b/exporter/f5cloudexporter/metadata.yaml @@ -3,7 +3,8 @@ type: f5cloud status: class: exporter stability: - beta: [traces, metrics, logs] + deprecated: [traces, metrics, logs] distributions: [contrib, observiq] codeowners: - active: [gramidt] + active: [] + emeritus: [gramidt] From 0b9ba42f49c1880f60a435fcb9f2b1680b67f396 Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Mon, 12 Feb 2024 09:33:19 -0800 Subject: [PATCH 2/3] changelog Signed-off-by: Alex Boten --- .chloggen/codeboten_deprecate-f5exporter.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100755 .chloggen/codeboten_deprecate-f5exporter.yaml diff --git a/.chloggen/codeboten_deprecate-f5exporter.yaml b/.chloggen/codeboten_deprecate-f5exporter.yaml new file mode 100755 index 000000000000..69ea75b9c480 --- /dev/null +++ b/.chloggen/codeboten_deprecate-f5exporter.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: deprecation + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: f5cloudexporter + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: deprecating component that is no longer maintained + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [31186] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [] From d47078c4f07cd11e3c465073163519c217d34da2 Mon Sep 17 00:00:00 2001 From: Alex Boten Date: Mon, 12 Feb 2024 09:58:13 -0800 Subject: [PATCH 3/3] tidy Signed-off-by: Alex Boten --- cmd/configschema/go.mod | 3 --- cmd/otelcontribcol/builder-config.yaml | 1 - cmd/otelcontribcol/components.go | 2 -- cmd/otelcontribcol/go.mod | 2 +- go.mod | 3 --- internal/components/components.go | 2 -- 6 files changed, 1 insertion(+), 12 deletions(-) diff --git a/cmd/configschema/go.mod b/cmd/configschema/go.mod index 04bc7581257d..8171058fe75a 100644 --- a/cmd/configschema/go.mod +++ b/cmd/configschema/go.mod @@ -480,7 +480,6 @@ require ( github.com/open-telemetry/opentelemetry-collector-contrib/connector/spanmetricsconnector v0.94.0 // indirect github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awskinesisexporter v0.94.0 // indirect github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter v0.94.0 // indirect - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter v0.94.0 // indirect github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter v0.94.0 // indirect github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter v0.94.0 // indirect github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlemanagedprometheusexporter v0.94.0 // indirect @@ -780,8 +779,6 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynat replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter => ../../exporter/elasticsearchexporter -replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter => ../../exporter/f5cloudexporter - replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter => ../../exporter/fileexporter replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter => ../../exporter/googlecloudexporter diff --git a/cmd/otelcontribcol/builder-config.yaml b/cmd/otelcontribcol/builder-config.yaml index 29a1c1ba0c51..2508faff01fd 100644 --- a/cmd/otelcontribcol/builder-config.yaml +++ b/cmd/otelcontribcol/builder-config.yaml @@ -62,7 +62,6 @@ exporters: - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter v0.94.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter v0.94.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter v0.94.0 - - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter v0.94.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.94.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter v0.94.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter v0.94.0 diff --git a/cmd/otelcontribcol/components.go b/cmd/otelcontribcol/components.go index 3c4e187a0d05..b5049ad1c807 100644 --- a/cmd/otelcontribcol/components.go +++ b/cmd/otelcontribcol/components.go @@ -42,7 +42,6 @@ import ( datasetexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter" dynatraceexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter" elasticsearchexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter" - f5cloudexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter" fileexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter" googlecloudexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter" googlecloudpubsubexporter "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter" @@ -359,7 +358,6 @@ func components() (otelcol.Factories, error) { datasetexporter.NewFactory(), dynatraceexporter.NewFactory(), elasticsearchexporter.NewFactory(), - f5cloudexporter.NewFactory(), fileexporter.NewFactory(), googlecloudexporter.NewFactory(), googlecloudpubsubexporter.NewFactory(), diff --git a/cmd/otelcontribcol/go.mod b/cmd/otelcontribcol/go.mod index 5041df63c807..395687a185d9 100644 --- a/cmd/otelcontribcol/go.mod +++ b/cmd/otelcontribcol/go.mod @@ -28,7 +28,7 @@ require ( github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter v0.94.0 - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter v0.94.0 + github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter v0.0.0-00010101000000-000000000000 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter v0.94.0 diff --git a/go.mod b/go.mod index 39d040f0839f..28b4106b2c7d 100644 --- a/go.mod +++ b/go.mod @@ -24,7 +24,6 @@ require ( github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter v0.94.0 - github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter v0.94.0 github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter v0.94.0 @@ -778,8 +777,6 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datas replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter => ./exporter/dynatraceexporter -replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter => ./exporter/f5cloudexporter - replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter => ./exporter/fileexporter replace github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter => ./exporter/googlecloudexporter diff --git a/internal/components/components.go b/internal/components/components.go index fa30e4294933..f1dd0c20be69 100644 --- a/internal/components/components.go +++ b/internal/components/components.go @@ -42,7 +42,6 @@ import ( "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter" "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter" "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter" - "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/f5cloudexporter" "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter" "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudexporter" "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/googlecloudpubsubexporter" @@ -328,7 +327,6 @@ func Components() (otelcol.Factories, error) { debugexporter.NewFactory(), dynatraceexporter.NewFactory(), elasticsearchexporter.NewFactory(), - f5cloudexporter.NewFactory(), fileexporter.NewFactory(), googlecloudexporter.NewFactory(), googlemanagedprometheusexporter.NewFactory(),