Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] Workaround integration test failures #2086

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 20, 2024

It seems latest/current Testcontainers.MsSql version isn't compatible with GitHub runners which were pushed out. This PR manually sets the image version temporarily so things will work. Also looks like the SqlEdge package has been completely deprecated. We're not currently running that in our CI but we might start if ARM gets introduced.

For details see: testcontainers/testcontainers-dotnet#1265

@github-actions github-actions bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (71655ce) to head (7675536).
Report is 444 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2086       +/-   ##
===========================================
+ Coverage   73.91%   90.90%   +16.99%     
===========================================
  Files         267        7      -260     
  Lines        9615      286     -9329     
===========================================
- Hits         7107      260     -6847     
+ Misses       2508       26     -2482     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 90.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 274 files with indirect coverage changes

@CodeBlanch CodeBlanch changed the title [sql] Investigate test failures [sql] Workaround integration test failures Sep 20, 2024
@CodeBlanch CodeBlanch marked this pull request as ready for review September 20, 2024 21:19
@CodeBlanch CodeBlanch requested a review from a team as a code owner September 20, 2024 21:19
@Kielek Kielek merged commit 8be3ff2 into open-telemetry:main Sep 24, 2024
59 checks passed
@CodeBlanch CodeBlanch deleted the sql-test-failures branch September 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants