From 8ba3f4a5b0018851caa303ae525bccf9e4196b04 Mon Sep 17 00:00:00 2001 From: joegoldman2 <147369450+joegoldman@users.noreply.github.com> Date: Fri, 4 Oct 2024 08:02:10 +0000 Subject: [PATCH 1/2] [Instrumentation.SqlClient] Remove .NET 6 target --- .../OpenTelemetry.Instrumentation.SqlClient.csproj | 8 ++++---- .../OpenTelemetry.Instrumentation.SqlClient.Tests.csproj | 5 +++-- .../SqlClientIntegrationTestsFixture.cs | 2 +- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/OpenTelemetry.Instrumentation.SqlClient.csproj b/src/OpenTelemetry.Instrumentation.SqlClient/OpenTelemetry.Instrumentation.SqlClient.csproj index 8b38c96bd0..26c571d46d 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/OpenTelemetry.Instrumentation.SqlClient.csproj +++ b/src/OpenTelemetry.Instrumentation.SqlClient/OpenTelemetry.Instrumentation.SqlClient.csproj @@ -1,15 +1,15 @@ - net8.0;net6.0;netstandard2.0 + net8.0;$(NetStandardMinimumSupportedVersion) $(TargetFrameworks);$(NetFrameworkMinimumSupportedVersion) - SqlClient instrumentation for OpenTelemetry .NET + SqlClient instrumentation for OpenTelemetry .NET. $(PackageTags);distributed-tracing Instrumentation.SqlClient- - + true diff --git a/test/OpenTelemetry.Instrumentation.SqlClient.Tests/OpenTelemetry.Instrumentation.SqlClient.Tests.csproj b/test/OpenTelemetry.Instrumentation.SqlClient.Tests/OpenTelemetry.Instrumentation.SqlClient.Tests.csproj index 5c3e4d90a2..730389a718 100644 --- a/test/OpenTelemetry.Instrumentation.SqlClient.Tests/OpenTelemetry.Instrumentation.SqlClient.Tests.csproj +++ b/test/OpenTelemetry.Instrumentation.SqlClient.Tests/OpenTelemetry.Instrumentation.SqlClient.Tests.csproj @@ -1,8 +1,9 @@ + Unit test project for OpenTelemetry SqlClient instrumentations - $(SupportedNetTargets) - $(TargetFrameworks);net462 + $(SupportedNetTargetsWithoutNet6) + $(TargetFrameworks);$(NetFrameworkMinimumSupportedVersion) diff --git a/test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlClientIntegrationTestsFixture.cs b/test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlClientIntegrationTestsFixture.cs index 57e0c85c6f..28e39184bf 100644 --- a/test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlClientIntegrationTestsFixture.cs +++ b/test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlClientIntegrationTestsFixture.cs @@ -29,7 +29,7 @@ public Task DisposeAsync() private static SqlEdgeContainer CreateSqlEdge() { // Note: The Testcontainers.SqlEdge package has been deprecated. Seems - // it will not work with newer GItHub-hosted runners. Need to find an + // it will not work with newer GitHub-hosted runners. Need to find an // alternative solution. See: // https://github.com/testcontainers/testcontainers-dotnet/pull/1265 return new SqlEdgeBuilder().Build(); From 66441c0ecbbaf0b9499d6b1bb9b4e707331b1942 Mon Sep 17 00:00:00 2001 From: joegoldman2 <147369450+joegoldman@users.noreply.github.com> Date: Fri, 4 Oct 2024 08:04:15 +0000 Subject: [PATCH 2/2] Add changelog entry --- src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md index 359f58a146..fa9054cb07 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Drop support for .NET 6 as this target is no longer supported. + ([#2159](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2159)) + ## 1.9.0-beta.1 Released 2024-Jun-17