Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger/Zipkin remote endpoint cache improvements #1235

Closed
alanwest opened this issue Sep 4, 2020 · 1 comment
Closed

Jaeger/Zipkin remote endpoint cache improvements #1235

alanwest opened this issue Sep 4, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@alanwest
Copy link
Member

alanwest commented Sep 4, 2020

Zipkin had a remote endpoint cache to reduce allocations:

#if !NET452
remoteEndpoint = RemoteEndpointCache.GetOrAdd((hostNameOrIpAddress, attributeEnumerationState.Port), ZipkinEndpoint.Create);
#else
var remoteEndpointStr = attributeEnumerationState.Port != default
? $"{hostNameOrIpAddress}:{attributeEnumerationState.Port}"
: hostNameOrIpAddress;
remoteEndpoint = RemoteEndpointCache.GetOrAdd(remoteEndpointStr, ZipkinEndpoint.Create);
#endif

Jaeger does not have a cache. @CodeBlanch and I discussed (#1195 (comment)) making one.

I've also raised a concern regarding the potential for unbounded memory growth of Zipkin's cache: #1168 (comment)

At a minimum, we should add a cache for Jaeger, but we may also want to consider a cache expiration or size limit for both Jaeger and Zipkin.

@alanwest alanwest added the enhancement New feature or request label Sep 4, 2020
@martinjt
Copy link
Member

Work has been done here, please reopen if you think there is more to be done however, these exporters are being thought about, separately, as candidates to move into contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants