Fix validation for tracestate with vendor and add tests #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Aneurysm9
approved these changes
Feb 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #1581 +/- ##
=====================================
Coverage 77.6% 77.6%
=====================================
Files 128 128
Lines 6635 6635
=====================================
+ Hits 5149 5155 +6
+ Misses 1239 1233 -6
Partials 247 247
|
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
…ry#1581) * Fix validation for tracestate with vendor * Add changes to changelog
This was referenced Mar 7, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceContext specification allows digits to be placed at the beginning of tracestate key for multi-tenant vendor scenario, this updates our implementation to match.
Additionally it adds test cases from the W3C unit tests to test this change and other regresions identified there.
Resolves #1475