Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: upgrade yaml package to v3 #4533

Closed
MrAlias opened this issue Sep 19, 2023 · 0 comments · Fixed by #4535
Closed

schema: upgrade yaml package to v3 #4533

MrAlias opened this issue Sep 19, 2023 · 0 comments · Fixed by #4535
Assignees
@MrAlias
Milestone
v1.19.0/v0.42.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 19, 2023

Currently the schema package uses gopkg.in/yaml.v2:

opentelemetry-go/schema/go.mod

Line 8 in bf54101

gopkg.in/yaml.v2 v2.4.0

This likely has to due to the strict parsing done there:

opentelemetry-go/schema/v1.1/parser.go

Line 46 in bf54101

d.SetStrict(true) // Do not silently drop unknown fields.

Determine if there is an equivalent process for gopkg.in/yaml.v3 and upgrade the dependency.
@MrAlias MrAlias converted this from a draft issue Sep 19, 2023
@MrAlias MrAlias changed the title Upgrade yaml package to v3 schema: upgrade yaml package to v3 Sep 19, 2023
This was referenced Sep 19, 2023
Closed
Merged
@MrAlias MrAlias self-assigned this Sep 20, 2023
@MrAlias MrAlias moved this from Todo to In Progress in Go: Schema v1 Sep 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Schema v1 Sep 21, 2023
@MrAlias MrAlias modified the milestones: v1.20.0, v1.19.0/v0.42.0 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
No open projects
Go: Schema v1
Status: Done
Milestone
v1.19.0/v0.42.0
Development

Successfully merging a pull request may close this issue.

Upgrade gopkg.io/yaml from v2 to v3 in schema MrAlias/opentelemetry-go
1 participant
@MrAlias