-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embedded package to trace API #4545
Comments
The current no-op trace implementation lives in I'm working on a solution to this that will deprecate the |
There is still an open question about the no-op package design in how the It should be easy enough for users who want this propagation behavior to wrap the noop implementation with one that does it. |
Is this not related to the comment above #4027? |
From SIG meeting:
|
I had some code of mine where I used gomock to stub out implementations of TracerProvider/Tracer/Span. This now no longer works, because these interfaces contain private methods. The stubs that gomock generates obviously don't contain the private methods. Thanks. |
@EdSchouten We have the same problem. |
Similar to the metric
embedded
package, add one for the trace API exported interfaces.This will, similarly, force SDK developers to make a choice on how they want unimplemented behavior to be handled.
The text was updated successfully, but these errors were encountered: