-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding summary support to metricdata #4587
Comments
See #4600 for what adding the summary type to the data model and bridge would look like. It does not require introducing the Summary type in the SDK (e.g. through views), since the Aggregation used in the view's Stream differs from metricdata.Aggregation. |
Current exporters, have switch statements over Data.(type) of the aggregation, and either error on unknown values, or ignore them. So this would be a relatively safe change. We would want to follow-up by introducing summary support to OTLP and Prometheus exporters. opentelemetry-go/exporters/prometheus/exporter.go Lines 217 to 230 in 68241af
opentelemetry-go/exporters/otlp/otlpmetric/otlpmetricgrpc/internal/transform/metricdata.go Lines 95 to 114 in 68241af
|
We discussed this at the SIG meeting yesterday, and are going to move forward with adding this to the metricdata package. |
#4571 is currently blocked on a spec decision. In the meantime, we can at least look at what adding summary support would look like in the Go SDK with a prototype.
The text was updated successfully, but these errors were encountered: