New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance golangci-lint configuration #1179

Closed

pellared opened this issue Oct 17, 2022 · 0 comments · Fixed by #1287

Assignees

Labels

Member

pellared commented Oct 17, 2022 •

edited

Loading

When reviewing #1177 I spotted that the current .golangci.yaml is very minimalistic.

I would consider enabling the following linters:

gosimple -it is enabled by default
staticcheck - enabled by default
ineffassign - enabled by default
typecheck - enabled by default - it makes the errors better if the code does not compile 😉
unused - enabled by default
unparam
nolintlint

I also like these but they may require some changes in the codebase

revive - golint replacement
errcheck - enabled by default

Might be nice to consider enabling this one as well

gofumpt

pavolloffay added the help wanted label

yuriolisa self-assigned this

yuriolisa mentioned this issue

Added linters #1287

Merged

pavolloffay closed this as completed in #1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment